Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix manager.js ignored when sideEffects:false in package.json #21335

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

ndelangen
Copy link
Member

Closes #

What I did

Add esbuild config to ignore side-effect:false in the user's package.json

see: https://esbuild.github.io/api/#ignore-annotations

How to test

  • Add a manager.js file to a project using storybook
  • Add a console.log('HELLO') in this manager.js
  • Set side-effects: false in package.json
  • start storybook
  • expect to see "HELLO" in the console in the manager frame

@shilman shilman changed the title Fix: manager.js being ignored/empty when side-effects:false in package.json Core: Fix manager.js ignored when side-effects:false in package.json Mar 1, 2023
@ndelangen ndelangen self-assigned this Mar 1, 2023
@ndelangen ndelangen requested a review from shilman March 1, 2023 15:49
@ndelangen ndelangen changed the title Core: Fix manager.js ignored when side-effects:false in package.json Core: Fix manager.js ignored when sideEffects:false in package.json Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants