Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csf Tools: Support satisfies and as TS operator with module.exports #21188

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 21, 2023

What I did

The way we parse main.js, specifically when module.exports is used, did not account for either as or satisfies Typescript operators:

module.exports = {
} as X

// or
const config = {} as X
module.exports = config

// or
module.exports = {
} satisfies X

// or
const config = {} satisfies X
module.exports = config

This PR fixes that!

How to test

Check the unit tests

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 85e4208 into next Feb 21, 2023
@shilman shilman deleted the fix/csf-tools-ts-expressions-module-exports branch February 21, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants