Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Undo AST main.js check in validateConfigFile #20952

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 6, 2023

Closes #20940

What I did

#20802 introduced unintended side effects, and the check will be moved into an automigration.
For now, we remove the code which is causing breakage.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package Eval Type Location Source
@storybook/[email protected] (added) Function dist/formatter-GCLXO5IP.mjs code/addons/a11y/package.json, code/addons/actions/package.json, code/addons/backgrounds/package.json, code/addons/controls/package.json via @storybook/[email protected], code/addons/docs/package.json via @storybook/[email protected], code/addons/essentials/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/interactions/package.json, code/addons/jest/package.json, code/addons/measure/package.json, code/addons/outline/package.json, code/addons/storyshots-core/package.json via @storybook/[email protected], @storybook/[email protected], code/addons/storysource/package.json, code/addons/toolbars/package.json, code/addons/viewport/package.json, code/frameworks/angular/package.json via @storybook/[email protected], code/frameworks/ember/package.json via @storybook/[email protected], code/frameworks/html-webpack5/package.json via @storybook/[email protected], code/frameworks/nextjs/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/preact-webpack5/package.json via @storybook/[email protected], code/frameworks/react-webpack5/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/svelte-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-webpack5/package.json via @storybook/[email protected], code/frameworks/vue3-webpack5/package.json via @storybook/[email protected], code/frameworks/web-components-webpack5/package.json via @storybook/[email protected], code/lib/builder-webpack5/package.json, code/ui/blocks/package.json via @storybook/[email protected], code/ui/manager/package.json
@storybook/[email protected] (added) Function dist/formatter-GCLXO5IP.mjs code/addons/a11y/package.json, code/addons/actions/package.json, code/addons/backgrounds/package.json, code/addons/controls/package.json via @storybook/[email protected], code/addons/docs/package.json via @storybook/[email protected], code/addons/essentials/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/interactions/package.json, code/addons/jest/package.json, code/addons/measure/package.json, code/addons/outline/package.json, code/addons/storyshots-core/package.json via @storybook/[email protected], @storybook/[email protected], code/addons/storysource/package.json, code/addons/toolbars/package.json, code/addons/viewport/package.json, code/frameworks/angular/package.json via @storybook/[email protected], code/frameworks/ember/package.json via @storybook/[email protected], code/frameworks/html-webpack5/package.json via @storybook/[email protected], code/frameworks/nextjs/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/preact-webpack5/package.json via @storybook/[email protected], code/frameworks/react-webpack5/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/svelte-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-webpack5/package.json via @storybook/[email protected], code/frameworks/vue3-webpack5/package.json via @storybook/[email protected], code/frameworks/web-components-webpack5/package.json via @storybook/[email protected], code/lib/builder-webpack5/package.json, code/ui/blocks/package.json via @storybook/[email protected], code/ui/manager/package.json
@storybook/[email protected] (added) Function dist/chunk-NDDCRJZ5.mjs code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-vite/package.json via @storybook/[email protected], code/frameworks/vue3-vite/package.json via @storybook/[email protected], code/frameworks/web-components-vite/package.json via @storybook/[email protected], code/lib/builder-manager/package.json, code/lib/cli/package.json via @storybook/[email protected], code/lib/cli-sb/package.json via @storybook/[email protected], code/lib/cli-storybook/package.json via @storybook/[email protected], code/lib/core-server/package.json via @storybook/[email protected], code/presets/server-webpack/package.json via @storybook/[email protected]
@storybook/[email protected] (added) Function dist/chunk-NDDCRJZ5.mjs code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-vite/package.json via @storybook/[email protected], code/frameworks/vue3-vite/package.json via @storybook/[email protected], code/frameworks/web-components-vite/package.json via @storybook/[email protected], code/lib/builder-manager/package.json, code/lib/cli/package.json via @storybook/[email protected], code/lib/cli-sb/package.json via @storybook/[email protected], code/lib/cli-storybook/package.json via @storybook/[email protected], code/lib/core-server/package.json via @storybook/[email protected], code/presets/server-webpack/package.json via @storybook/[email protected]
@storybook/[email protected] (added) Function dist/chunk-NDDCRJZ5.mjs code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-vite/package.json via @storybook/[email protected], code/frameworks/vue3-vite/package.json via @storybook/[email protected], code/frameworks/web-components-vite/package.json via @storybook/[email protected], code/lib/builder-manager/package.json, code/lib/cli/package.json via @storybook/[email protected], code/lib/cli-sb/package.json via @storybook/[email protected], code/lib/cli-storybook/package.json via @storybook/[email protected], code/lib/core-server/package.json via @storybook/[email protected], code/presets/server-webpack/package.json via @storybook/[email protected]
@storybook/[email protected] (added) Function dist/chunk-NDDCRJZ5.mjs code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-vite/package.json via @storybook/[email protected], code/frameworks/vue3-vite/package.json via @storybook/[email protected], code/frameworks/web-components-vite/package.json via @storybook/[email protected], code/lib/builder-manager/package.json, code/lib/cli/package.json via @storybook/[email protected], code/lib/cli-sb/package.json via @storybook/[email protected], code/lib/cli-storybook/package.json via @storybook/[email protected], code/lib/core-server/package.json via @storybook/[email protected], code/presets/server-webpack/package.json via @storybook/[email protected]
@storybook/[email protected] (added) Function dist/chunk-NDDCRJZ5.mjs code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-vite/package.json via @storybook/[email protected], code/frameworks/vue3-vite/package.json via @storybook/[email protected], code/frameworks/web-components-vite/package.json via @storybook/[email protected], code/lib/builder-manager/package.json, code/lib/cli/package.json via @storybook/[email protected], code/lib/cli-sb/package.json via @storybook/[email protected], code/lib/cli-storybook/package.json via @storybook/[email protected], code/lib/core-server/package.json via @storybook/[email protected], code/presets/server-webpack/package.json via @storybook/[email protected]
@storybook/[email protected] (added) Function dist/chunk-NDDCRJZ5.mjs code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-vite/package.json via @storybook/[email protected], code/frameworks/vue3-vite/package.json via @storybook/[email protected], code/frameworks/web-components-vite/package.json via @storybook/[email protected], code/lib/builder-manager/package.json, code/lib/cli/package.json via @storybook/[email protected], code/lib/cli-sb/package.json via @storybook/[email protected], code/lib/cli-storybook/package.json via @storybook/[email protected], code/lib/core-server/package.json via @storybook/[email protected], code/presets/server-webpack/package.json via @storybook/[email protected]
@storybook/[email protected] (added) Function dist/chunk-NDDCRJZ5.mjs code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-vite/package.json via @storybook/[email protected], code/frameworks/vue3-vite/package.json via @storybook/[email protected], code/frameworks/web-components-vite/package.json via @storybook/[email protected], code/lib/builder-manager/package.json, code/lib/cli/package.json via @storybook/[email protected], code/lib/cli-sb/package.json via @storybook/[email protected], code/lib/cli-storybook/package.json via @storybook/[email protected], code/lib/core-server/package.json via @storybook/[email protected], code/presets/server-webpack/package.json via @storybook/[email protected]
@storybook/[email protected] (added) Function dist/formatter-GCLXO5IP-SA57GC6A.mjs code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-vite/package.json via @storybook/[email protected], code/frameworks/vue3-vite/package.json via @storybook/[email protected], code/frameworks/web-components-vite/package.json via @storybook/[email protected], code/lib/builder-manager/package.json, code/lib/cli/package.json via @storybook/[email protected], code/lib/cli-sb/package.json via @storybook/[email protected], code/lib/cli-storybook/package.json via @storybook/[email protected], code/lib/core-server/package.json via @storybook/[email protected], code/presets/server-webpack/package.json via @storybook/[email protected]
@storybook/[email protected] (added) Function dist/formatter-GCLXO5IP-SA57GC6A.mjs code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/vue-vite/package.json via @storybook/[email protected], code/frameworks/vue3-vite/package.json via @storybook/[email protected], code/frameworks/web-components-vite/package.json via @storybook/[email protected], code/lib/builder-manager/package.json, code/lib/cli/package.json via @storybook/[email protected], code/lib/cli-sb/package.json via @storybook/[email protected], code/lib/cli-storybook/package.json via @storybook/[email protected], code/lib/core-server/package.json via @storybook/[email protected], code/presets/server-webpack/package.json via @storybook/[email protected]
@storybook/[email protected] (added) Function dist/index.js code/package.json via @storybook/[email protected], code/addons/docs/package.json
@storybook/[email protected] (added) Function dist/index.mjs code/package.json via @storybook/[email protected], code/addons/docs/package.json
@storybook/[email protected] (added) Function dist/runtime.js code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], code/frameworks/ember/package.json via @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/html-webpack5/package.json via @storybook/[email protected], code/frameworks/nextjs/package.json via @storybook/[email protected], code/frameworks/preact-vite/package.json via @storybook/[email protected], code/frameworks/preact-webpack5/package.json via @storybook/[email protected], code/frameworks/react-vite/package.json via @storybook/[email protected], code/frameworks/react-webpack5/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/svelte-vite/package.json via @storybook/[email protected], code/frameworks/svelte-webpack5/package.json via @storybook/[email protected], code/frameworks/sveltekit/package.json via @storybook/[email protected], @storybook/[email protected], code/frameworks/vue-vite/package.json via @storybook/[email protected], code/frameworks/vue-webpack5/package.json via @storybook/[email protected], code/frameworks/vue3-vite/package.json via @storybook/[email protected], code/frameworks/vue3-webpack5/package.json via @storybook/[email protected], code/frameworks/web-components-vite/package.json via @storybook/[email protected], code/frameworks/web-components-webpack5/package.json via @storybook/[email protected], code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/runtime.js code/addons/storyshots-core/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @storybook/[email protected], code/frameworks/ember/package.json via @storybook/[email protected], code/frameworks/html-vite/package.json via @storybook/[email protected], code/frameworks/html-webpack5/package.json via @storybook/[email protected], code/frameworks/nextjs/package.json via @storybook/[email protected], code/frameworks/preact-vite/package.json via @storybook/[email protected], code/frameworks/preact-webpack5/package.json via @storybook/[email protected], code/frameworks/react-vite/package.json via @storybook/[email protected], code/frameworks/react-webpack5/package.json via @storybook/[email protected], code/frameworks/server-webpack5/package.json via @storybook/[email protected], code/frameworks/svelte-vite/package.json via @storybook/[email protected], [code/frameworks/svelte-webpack5/package.json](

@yannbf yannbf changed the title undo AST main.js check in validateConfigFile Core: Undo AST main.js check in validateConfigFile Feb 6, 2023
@yannbf yannbf merged commit 0da5c75 into next Feb 6, 2023
@yannbf yannbf deleted the fix/undo-mainjs-default-export-check branch February 6, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Babel warning when using a function for base configuration for angular
3 participants