Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade glob to 8.1.0 #20927

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Upgrade glob to 8.1.0 #20927

merged 1 commit into from
Feb 4, 2023

Conversation

chakAs3
Copy link
Contributor

@chakAs3 chakAs3 commented Feb 3, 2023

Closes #20926

What I did

basicly changed "glob" package version in mutliple places make it match the one that @storybook/test-runner requires "glob": "^8.1.0"

How to test

  1. Run a sandbox for template react or vue3
  2. should passe and install deps then run sb

-->

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package Eval Type Location Source
@angular/[email protected] (upgraded) Function esm2020/src/output/output_jit_trusted_types.mjs code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-core/package.json via [email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @angular-devkit/[email protected], @angular/[email protected], @angular/[email protected], [email protected]
@angular/[email protected] (upgraded) Function esm2020/src/output/output_jit_trusted_types.mjs code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-core/package.json via [email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @angular-devkit/[email protected], @angular/[email protected], @angular/[email protected], [email protected]
@angular/[email protected] (upgraded) Function esm2020/src/util/security/trusted_types.mjs code/addons/storyshots-core/package.json via @angular/[email protected], [email protected]
@angular/[email protected] (upgraded) Function esm2020/src/util/security/trusted_types.mjs code/addons/storyshots-core/package.json via @angular/[email protected], [email protected]
@angular/[email protected] (upgraded) Function schematics/utils/load_esm.js code/addons/storyshots-core/package.json via @angular/[email protected], [email protected]
@angular/[email protected] (upgraded) Function esm2020/src/util/security/trusted_types.mjs code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-core/package.json via [email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @angular-devkit/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], [email protected]
@angular/[email protected] (upgraded) Function esm2020/src/util/security/trusted_types.mjs code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-core/package.json via [email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @angular-devkit/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], [email protected]
@angular/[email protected] (upgraded) Function fesm2015/testing.mjs code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-core/package.json via [email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @angular-devkit/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], [email protected]
@angular/[email protected] (upgraded) Function fesm2015/testing.mjs code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-core/package.json via [email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @angular-devkit/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], [email protected]
@angular/[email protected] (upgraded) Function fesm2020/testing.mjs code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-core/package.json via [email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @angular-devkit/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], [email protected]
@angular/[email protected] (upgraded) Function fesm2020/testing.mjs code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-core/package.json via [email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @angular-devkit/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], @angular/[email protected], [email protected]
@ngtools/[email protected] (added) Function src/ivy/plugin.js code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-core/package.json via [email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @angular-devkit/[email protected], [email protected]
@ngtools/[email protected] (added) Function src/ivy/plugin.js code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-core/package.json via [email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], code/frameworks/angular/package.json via @angular-devkit/[email protected], [email protected]
@reach/[email protected] (added) Function dist/utils.cjs.development.js test-storybooks/external-docs/package.json via [email protected]
@reach/[email protected] (added) Function dist/utils.cjs.production.min.js test-storybooks/external-docs/package.json via [email protected]
@reach/[email protected] (added) Function dist/utils.esm.js test-storybooks/external-docs/package.json via [email protected]
@sinclair/[email protected] (added) Function compiler/compiler.js code/addons/storyshots-core/package.json via @jest/[email protected], [email protected], [email protected], [email protected], [email protected], code/frameworks/angular/package.json via [email protected], [email protected]
@sinclair/[email protected] (added) Function conditional/structural.js code/addons/storyshots-core/package.json via @jest/[email protected], [email protected], [email protected], [email protected], [email protected], code/frameworks/angular/package.json via [email protected], [email protected]
@sinclair/[email protected] (added) Function errors/errors.js code/addons/storyshots-core/package.json via @jest/[email protected], [email protected], [email protected], [email protected], [email protected], code/frameworks/angular/package.json via [email protected], [email protected]
@sinclair/[email protected] (added) Function value/cast.js code/addons/storyshots-core/package.json via @jest/[email protected], [email protected], [email protected], [email protected], [email protected], code/frameworks/angular/package.json via [email protected], [email protected]
@sinclair/[email protected] (added) Function value/check.js code/addons/storyshots-core/package.json via @jest/[email protected], [email protected], [email protected], [email protected], [email protected], code/frameworks/angular/package.json via [email protected], [email protected]
@sinclair/[email protected] (added) Function value/create.js code/addons/storyshots-core/package.json via @jest/[email protected], [email protected], [email protected], [email protected], [email protected], code/frameworks/angular/package.json via [email protected], [email protected]
@storybook/[email protected] (added) Function dist/formatter-UBTKRH7D.mjs test-storybooks/ember-cli/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/external-docs/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/server-kitchen-sink/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/standalone-preview/package.json via @storybook/[email protected], @storybook/[email protected]
@storybook/[email protected] (added) Function dist/formatter-UBTKRH7D.mjs test-storybooks/ember-cli/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/external-docs/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/server-kitchen-sink/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/standalone-preview/package.json via @storybook/[email protected], @storybook/[email protected]
@storybook/[email protected] (added) Function dist/index.js test-storybooks/ember-cli/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/external-docs/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/server-kitchen-sink/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/standalone-preview/package.json via @storybook/[email protected], @storybook/[email protected]
@storybook/[email protected] (added) Function dist/index.js test-storybooks/ember-cli/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/external-docs/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/server-kitchen-sink/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], test-storybooks/standalone-preview/package.json via @storybook/[email protected], @storybook/[email protected]
@storybook/[email protected] (added) Function dist/chunk-BQTLD2LG.mjs code/lib/builder-manager/package.json
@storybook/[email protected] (added) Function dist/chunk-BQTLD2LG.mjs code/lib/builder-manager/package.json
@storybook/[email protected] (added) Function dist/chunk-BQTLD2LG.mjs code/lib/builder-manager/package.json
@storybook/[email protected] (added) Function dist/chunk-BQTLD2LG.mjs code/lib/builder-manager/package.json
@storybook/[email protected] (added) Function dist/chunk-BQTLD2LG.mjs code/lib/builder-manager/package.json
@storybook/[email protected] (added) Function dist/chunk-BQTLD2LG.mjs code/lib/builder-manager/package.json
@storybook/[email protected] (added) Function dist/chunk-BQTLD2LG.mjs code/lib/builder-manager/package.json
@storybook/[email protected] (added) Function dist/formatter-GCLXO5IP-SA57GC6A.mjs code/lib/builder-manager/package.json
@storybook/[email protected] (added) Function dist/formatter-GCLXO5IP-SA57GC6A.mjs code/lib/builder-manager/package.json
@storybook/[email protected] (added) Function dist/index.js code/package.json via @storybook/[email protected], code/addons/docs/package.json
@storybook/[email protected] (added) Function dist/index.mjs code/package.json via @storybook/[email protected], code/addons/docs/package.json
@storybook/[email protected] (added) Function dist/runtime.js code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/runtime.js code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/runtime.js code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/runtime.js code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/runtime.js code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/runtime.mjs code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/runtime.mjs code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/runtime.mjs code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/runtime.mjs code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/runtime.mjs code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/[email protected] (added) Function dist/cjs/index.js code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], code/addons/interactions/package.json via @storybook/[email protected], @storybook/[email protected], code/addons/storyshots-puppeteer/package.json via @storybook/[email protected], scripts/package.json via @storybook/[email protected], @storybook/[email protected]
@storybook/[email protected] (added) Function dist/esm/index.js code/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [@storybook/[email protected]](https://socke

@shilman shilman changed the title fix deps conflict on sandboxes install react, vue. Upgrade glob to 8.1.0 Feb 4, 2023
@shilman
Copy link
Member

shilman commented Feb 4, 2023

@yannbf this looks like a change in the test-runner that broke our ability to install linked sandboxes locally (verified). how can we avoid this happening in the future?

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: sandboxes are broken dependency conflict. ( beta.41 )
2 participants