Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Detect mdx2 errors and provide guidance to fix them #20917

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 3, 2023

What I did

MDX1 to MDX2 migration is frustrating. This PR helps that a little.

Before:
image

After:
image

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Force an MDX2 error
  3. Run storybook, expect an error

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf changed the title detect mdx2 errors and provide guidance to fix them Core: Detect mdx2 errors and provide guidance to fix them Feb 3, 2023
@yannbf yannbf self-assigned this Feb 3, 2023
@yannbf yannbf requested a review from shilman February 3, 2023 08:56
@yannbf yannbf force-pushed the fix/detect-mdx2-errors branch from 1785b13 to 81ec9f0 Compare February 9, 2023 11:47
@yannbf yannbf marked this pull request as ready for review February 9, 2023 11:49
@yannbf yannbf merged commit 8c6592f into next Feb 9, 2023
@yannbf yannbf deleted the fix/detect-mdx2-errors branch February 9, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants