Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return address of dev server from buildDevStandalone #20820

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

tobiasdiez
Copy link
Contributor

What I did

I currently use buildDevStandalone to start a dev server (by code), and to show a nice message to the user afterwards, I would like to get the server address. Thus, this information is returned now as well.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

I currently use `buildDevStandalone` to start a dev server (by code), and to show a nice message to the user afterwards, I would like to get the server address.
@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented Jan 31, 2023

Hey @tobiasdiez, Thank you for your contribution!

Might you take a look at the linting error?

storybook/code/lib/core-server/src/build-dev.ts
  33:26  error  Replace `,·address:·string,` with `;·address:·string;`  prettier/prettier

@tobiasdiez
Copy link
Contributor Author

@valentinpalkovic Sure, the linter should be happy now!

@valentinpalkovic valentinpalkovic self-requested a review February 1, 2023 10:07
@valentinpalkovic valentinpalkovic merged commit de4031a into storybookjs:next Feb 1, 2023
@tobiasdiez tobiasdiez deleted the patch-1 branch February 1, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants