Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Allow using <Source code=".." /> unattached. #20807

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Docs: Allow using <Source code=".." /> unattached. #20807

merged 2 commits into from
Jan 27, 2023

Conversation

tmeasday
Copy link
Member

Fixes: #20780

What I did

Allows no primary story in source block.

How to test

See added story.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday requested a review from JReinhold January 27, 2023 04:14
JReinhold
JReinhold approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, better than my approach in #20803 !

@JReinhold JReinhold merged commit 817666d into next Jan 27, 2023
@JReinhold JReinhold deleted the 20780-unattached-source-code branch January 27, 2023 19:53
@shilman shilman mentioned this pull request Jan 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees
No one assigned
Labels
addon: docs block: source bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: <Source code="xyz" /> fails in unattached docs.
2 participants
@tmeasday @JReinhold