Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react-popper-tooltip #20736

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Upgrade react-popper-tooltip #20736

merged 1 commit into from
Jan 23, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jan 23, 2023 •
edited
Loading

Issue: N/A

Upgraded react-popper-tooltip library

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic added maintenance User-facing maintenance tasks ui labels Jan 23, 2023
shilman
shilman approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @valentinpalkovic ! 🙏

@valentinpalkovic valentinpalkovic force-pushed the valentin/upgrade-react-popper-tooltip branch from 87454c3 to 04b9bef Compare January 23, 2023 08:48
@valentinpalkovic valentinpalkovic force-pushed the valentin/upgrade-react-popper-tooltip branch from 04b9bef to 1e77444 Compare January 23, 2023 10:25
@valentinpalkovic valentinpalkovic force-pushed the valentin/upgrade-react-popper-tooltip branch from 1e77444 to b003f78 Compare January 23, 2023 12:40
@valentinpalkovic valentinpalkovic merged commit c096972 into next Jan 23, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/upgrade-react-popper-tooltip branch January 23, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman shilman approved these changes

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@valentinpalkovic valentinpalkovic

Labels
maintenance User-facing maintenance tasks ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valentinpalkovic @shilman @ndelangen