Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Make missing-babelrc an automatic migration #20689

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 19, 2023

Issue: #20677

What I did

The missing-babelrc migration was promptOnly, and now can automatically run when the user responds with yes instead of asking them to run npx storybook@next babelrc.

image

How to test

  1. Check this branch and compile libraries: task --task compile
  2. Go to a Storybook project that needs a babelrc file, but don't include it
  3. Run sb automigrate missing-babelrc and see the automigration in action

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@shilman shilman changed the title CLI: turn missing-babelrc from manual to an automatic migration CLI: Make missing-babelrc an automatic migration Jan 19, 2023
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

@yannbf yannbf force-pushed the yann/sb-1174-improve-babelrc-automigration branch from f9de951 to 3854a7a Compare January 19, 2023 14:42
@yannbf yannbf force-pushed the yann/sb-1174-improve-babelrc-automigration branch from 3854a7a to f160d3b Compare January 19, 2023 16:13
@yannbf yannbf merged commit 36af49e into next Jan 19, 2023
@yannbf yannbf deleted the yann/sb-1174-improve-babelrc-automigration branch January 19, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants