Addon-docs: Update story index generator #20679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change extract stories condition to positive matcher instead of negative matcher
shilman
changed the title
shilman
reviewed
Jan 19, 2023
shilman
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Thanks so much @sheriffMoose. Love the post & the direction. Great stuff!!! 👏
shilman
added
maintenance
sheriffMoose
added a commit
to sheriffMoose/storybook
that referenced
this pull request
Jan 27, 2023
" storybookjs#20679 This reverts commits c425cc8 f1765bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the matcher for CSF stories works with all files including .stories.mdx files but not other .mdx files.
This behavior actually makes it difficult for developers to import other files as DocsOnly story, for example .md files like README.md & CHANGELOG.md.
For the current time being, the matcher is updated to match to any file with the extensions .js, .jsx, .ts, .tsx along with .stories.mdx.
Please read more about the motivation behind this PR in this article
https://sheriffmoose.medium.com/storybook-markdown-docs-not-mdx-part-2-757463fcad84
Issue
N/A
What I did
How to test