Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: handle undefined extractComponentDescription #20590

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Blocks: handle undefined extractComponentDescription #20590

merged 1 commit into from
Jan 12, 2023

Conversation

JReinhold
Copy link
Contributor

Fix Description block to not break when extractComponentDescription isn't defined, as it isn't in eg. Preact.

@JReinhold JReinhold self-assigned this Jan 12, 2023
@JReinhold JReinhold added bug ci:daily Run the CI jobs that normally run in the daily job. labels Jan 12, 2023
@JReinhold JReinhold requested a review from yannbf January 12, 2023 12:39
@yannbf yannbf added ci:merged Run the CI jobs that normally run when merged. ui and removed ci:daily Run the CI jobs that normally run in the daily job. labels Jan 12, 2023
@yannbf yannbf merged commit 0a76fb9 into next Jan 12, 2023
@yannbf yannbf deleted the fix-extractComponentDescription branch January 12, 2023 14:34
@jameschensmith jameschensmith mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

@yannbf yannbf Awaiting requested review from yannbf

Assignees

@JReinhold JReinhold

Labels
bug ci:merged Run the CI jobs that normally run when merged. ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JReinhold @valentinpalkovic @yannbf