Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations: Add preact-vite to new frameworks automigration. #20542

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Migrations: Add preact-vite to new frameworks automigration. #20542

merged 2 commits into from
Jan 10, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jan 9, 2023

@tmeasday tmeasday added maintenance User-facing maintenance tasks preact labels Jan 9, 2023
@tmeasday tmeasday changed the title Add test for preact-vite MigrationsAdd test for preact-vite Jan 9, 2023
@tmeasday tmeasday changed the title MigrationsAdd test for preact-vite Migrations: Add test for preact-vite Jan 9, 2023
@tmeasday tmeasday mentioned this pull request Jan 9, 2023
Closed
2 tasks
@tmeasday tmeasday requested a review from shilman January 9, 2023 05:39
@ndelangen ndelangen assigned tmeasday and unassigned ndelangen Jan 9, 2023
@ndelangen
Copy link
Member

@tmeasday can you fix the tests?

@tmeasday tmeasday changed the title Migrations: Add test for preact-vite Migrations: Add preact-vite to new frameworks automigration. Jan 10, 2023
@tmeasday tmeasday requested a review from yannbf January 10, 2023 04:23
@ndelangen ndelangen merged commit d364fe8 into next Jan 10, 2023
@ndelangen ndelangen deleted the preact-vite-upgrade-test branch January 10, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman Awaiting requested review from shilman

@yannbf yannbf Awaiting requested review from yannbf

Assignees

@tmeasday tmeasday

Labels
maintenance User-facing maintenance tasks preact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @ndelangen