-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: added ability to compose with basic auth storybooks #20488
Conversation
@enterframe I'd like to update this branch with changes upstream but you've blocked maintainers from pushing to your fork, can you please update your branch yourself? Or allow me to do it, and ping me? I'd like to merge this PR, but it's blocked on the above, 🙏 thanks!
|
@ndelangen I did not change any settings in the fork and yes you updated it successfully before 🤷♂️ I do not see any changes upstream but for safety's sake I added you as a maintainer.. 🤘 |
Issue:
When using storybooks composition feature, it was not possible to compose storybooks secured by basic-auth.
What I did
I just used the default style to predefine basic auth credentials in an url and proxied them forward to the fetch request
How to test
In the sandbox template define a basic auth secured ref, it will successfully show up in the storybook refs pane
/.storybook/main.cjs
If your answer is yes to any of these, please make sure to include it in your PR.