Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: added ability to compose with basic auth storybooks #20488

Merged
merged 6 commits into from
Jan 9, 2023

Conversation

enterframe
Copy link
Contributor

@enterframe enterframe commented Jan 3, 2023

Issue:
When using storybooks composition feature, it was not possible to compose storybooks secured by basic-auth.

What I did

I just used the default style to predefine basic auth credentials in an url and proxied them forward to the fetch request

How to test

In the sandbox template define a basic auth secured ref, it will successfully show up in the storybook refs pane

/.storybook/main.cjs

...
  "refs": {
    "shared-components": {
      "title": "Shared Components",
      "url": "https://user:[email protected]/"
    },
  },
...
  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman
Copy link
Member

shilman commented Jan 3, 2023

cc @ndelangen @tmeasday

@shilman shilman requested review from tmeasday and ndelangen January 4, 2023 08:35
@ndelangen ndelangen changed the title added ability to compose with basic auth storybooks Feature: added ability to compose with basic auth storybooks Jan 9, 2023
@ndelangen
Copy link
Member

ndelangen commented Jan 9, 2023

@enterframe I'd like to update this branch with changes upstream but you've blocked maintainers from pushing to your fork, can you please update your branch yourself? Or allow me to do it, and ping me?

I'd like to merge this PR, but it's blocked on the above, 🙏 thanks!

Screenshot 2023-01-09 at 21 00 05
Which is weird because it looks like I was able to do it before? 😕

@enterframe
Copy link
Contributor Author

enterframe commented Jan 9, 2023

@ndelangen I did not change any settings in the fork and yes you updated it successfully before 🤷‍♂️ I do not see any changes upstream but for safety's sake I added you as a maintainer.. 🤘

@ndelangen ndelangen merged commit 7ec50cb into storybookjs:next Jan 9, 2023
@ndelangen ndelangen deleted the basic-auth-composition branch January 9, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants