Make vue a peer dependency #2041
Conversation
Depend loosely on vue & vue-loader by moving them to peer dependencies.
|
@Hypnosphi Once merge #2032 to |
|
I mean, that one needs review, but it partially interleaves with this one, so I'm not sure what should we do |
app/vue/package.json
Outdated
| "vue-template-compiler": "^2.5.2", | ||
| }, | ||
| "peerDependencies": { | ||
| "vue": "*", |
There was a problem hiding this comment.
Can we check that we work with any vue version?
There was a problem hiding this comment.
I think that we should be checked vue latest version only. because vue-template-compiler forces the same version as vue
There was a problem hiding this comment.
I mean, do we work with vue version 1? If not, we shouldn't put an asterisk here
app/vue/package.json
Outdated
| "nodemon": "^1.12.1", | ||
| "vue": "^2.5.2", | ||
| "vue-loader": "^13.3.0", | ||
| "vue-template-compiler": "^2.5.2", |
There was a problem hiding this comment.
Trailing comma makes JSON invalid
| "vue": "^2.5.2", | ||
| "vue-hot-reload-api": "^2.2.0", | ||
| "vue-loader": "^12.2.1", | ||
| "vue-hot-reload-api": "^2.1.1", |
There was a problem hiding this comment.
Please run yarn install to update lockfile after you fix it
There was a problem hiding this comment.
Not a deal-breaking for this PR, TBH.
| "nodemon": "^1.12.1" | ||
| "nodemon": "^1.12.1", | ||
| "vue": "^2.5.2", | ||
| "vue-loader": "^13.3.0", |
There was a problem hiding this comment.
What are the breaking changes between 12 and 13?
There was a problem hiding this comment.
@Hypnosphi https://github.com/vuejs/vue-loader/releases/tag/v13.0.0
Upgrading vue-loader also fixes vuejs/vue-loader#951 (supporting nested css rules). Which is something I use heavily in my .vue files and that's currently blocking me from adding several components to my storybook.
So would love to see this getting merged eventually!
Codecov Report
@@ Coverage Diff @@
## master #2041 +/- ##
======================================
Coverage 21.4% 21.4%
======================================
Files 263 263
Lines 5793 5793
Branches 695 694 -1
======================================
Hits 1240 1240
- Misses 4009 4029 +20
+ Partials 544 524 -20
Continue to review full report at Codecov.
|
| "vue": "^2.5.2", | ||
| "vue-hot-reload-api": "^2.2.0", | ||
| "vue-loader": "^12.2.1", | ||
| "vue-hot-reload-api": "^2.1.1", |
There was a problem hiding this comment.
Not a deal-breaking for this PR, TBH.
| "nodemon": "^1.12.1" | ||
| "nodemon": "^1.12.1", | ||
| "vue": "^2.5.2", | ||
| "vue-loader": "^13.3.0", |
|
@Hypnosphi Looks like you have no huge objections to this PR, so I hope you don't mind me merging this as Vue-version mismatches are a huge problem for users. |
|
Thank you for your efforts @znck @kazupon @eriknygren @Hypnosphi 👍 💯 |
|
Actually, I had one, about the asterisk: #2041 (comment) |
What I did
Depend loosely on vue & vue-loader by moving them to peer dependencies. This allows end user to
pick any version of vue for their project.
How to test
Existing tests should pass.