Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: make tests use SWC, not babel #20397

Merged
merged 6 commits into from
Dec 23, 2022
Merged

Build: make tests use SWC, not babel #20397

merged 6 commits into from
Dec 23, 2022

Conversation

ifndefdeadmau5
Copy link

@ifndefdeadmau5 ifndefdeadmau5 commented Dec 23, 2022 •
edited
Loading

Issue: #18732

What I did

This is simply a extracted change from the original PR #20350 (since it ain't need to be telescoped onto other PRs)
See #20350 (comment)

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@ifndefdeadmau5 ifndefdeadmau5 changed the title Tech: make tests use SWC, not babel(cherry-picked from other PR) Tech: make tests use SWC, not babel(cherry-picked from #20350) Dec 23, 2022
@ndelangen ndelangen mentioned this pull request Dec 23, 2022
Closed
@ndelangen ndelangen self-requested a review December 23, 2022 14:52
@ndelangen ndelangen self-assigned this Dec 23, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Dec 23, 2022
@ndelangen
Copy link
Member

I tested it locally on my machine, and it works! congrats on this first PR @ifndefdeadmau5 !!

@ndelangen ndelangen changed the title Tech: make tests use SWC, not babel(cherry-picked from #20350) Tech: make tests use SWC, not babel Dec 23, 2022
@ndelangen ndelangen changed the title Tech: make tests use SWC, not babel Build: make tests use SWC, not babel Dec 23, 2022
@ndelangen ndelangen merged commit 222dff9 into storybookjs:next Dec 23, 2022
@ifndefdeadmau5 ifndefdeadmau5 deleted the tech/jest-swc-standalone branch December 23, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifndefdeadmau5 @ndelangen