Fix vite peerDep warning by updating @joshwooding/vite-plugin-react-docgen-typescript
#20359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
@joshwooding/vite-plugin-react-docgen-typescript
|
@joshwooding Any idea why the UI changes might appear? Did anything else upgrade? |
|
Looks like it's actually broken: https://www.chromatic.com/test?appId=630511d655df72125520f051&id=63a2cd9f194ba874e9861c3e 😢 |
|
@ndelangen @joshwooding looks like the plugin is broken in this PR? |
|
Yes, looks that way, upsetting... I do not know what's wrong.. |
|
After a bit of debugging I found the problem, it was an CJS => ESM thing. I'll open a PR @joshwooding |
Cool, I saw it was that ts.createProgram isn't a function because the async import returned a default object |
|
@shilman self merging |
ndelangen
deleted the
norbert/20179-pnpm-missing-typescript-peer-dependency-in-a-vitejs-project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #20179
What I did
The peerDependency issue was resolved upstream, this upgrades the dependecy to a version that no longer has the issue.
see: https://github.com/joshwooding/vite-plugin-react-docgen-typescript/blob/HEAD/CHANGELOG.md