Core: Wrap manager entries to handle exports using a cache directory #20331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
tmeasday and
shilman
and removed request for
tmeasday
ndelangen
changed the title
shilman
approved these changes
Dec 22, 2022
…js/storybook into fix/manager-entry-with-exports
ndelangen
changed the title
ndelangen
changed the title
|
I make this mistake all the time myself, but it's a bit risky to use types from before a breaking change. {
"@types/find-cache-dir": "^3.2.1",
"find-cache-dir": "^4.0.0",
}Maybe a test to check for mismatching types would be prudent? Anyways, this may be a pointer:
Wishing you the best of luck, and I'm looking forward to have this solved to get back on the newest beta version 🙏 |
|
Thanks for spotting that @VidunderGunder ❤️ I've opened a PR downgrading for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: managerEntries can break when they contains exports
What I did
see: #20308
This would also allow us to provide cleaner locations without special characters in the paths for managerEntries.