Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support useSelectedLayoutSegment and useSelectedLayoutSegments in Next.js #20330

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Support useSelectedLayoutSegment and useSelectedLayoutSegments in Next.js #20330

merged 1 commit into from
Dec 19, 2022

Conversation

valentinpalkovic
Copy link
Contributor

Issue: #20320

What I did

Added support for useSelectedLayoutSegment and useSelectedLayoutSegments hook in Storybook for Next.js Framework.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@valentinpalkovic valentinpalkovic marked this pull request as ready for review December 19, 2022 15:11
@yannbf yannbf added the ci:daily Run the CI jobs that normally run in the daily job. label Dec 19, 2022
yannbf
yannbf approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valentinpalkovic
Copy link
Contributor Author

@yannbf Please keep in mind that the daily jobs prevent us from merging because required jobs are not added to the workflow: #20263 Kasper will adjust the PR before it get merged. So do not wonder, if this PR is blocked from merging, after you have added the daily tag.

@yannbf yannbf removed the ci:daily Run the CI jobs that normally run in the daily job. label Dec 19, 2022
@yannbf
Copy link
Member

yannbf commented Dec 19, 2022

For sure @valentinpalkovic ! I just wanted to make sure the js version of nextjs ran in this PR, as the example stories you set were for js. Already reviewed Chromatic and all is good!

@valentinpalkovic valentinpalkovic merged commit 6aed0b0 into next Dec 19, 2022
@valentinpalkovic valentinpalkovic deleted the valentin/support-use-selected-layout-segment-in-next branch December 19, 2022 20:21
@shilman shilman mentioned this pull request Dec 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees
No one assigned
Labels
feature request nextjs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinpalkovic @yannbf