Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: fix automigrate filtering #20329

Merged
merged 2 commits into from
Dec 19, 2022
Merged

CLI: fix automigrate filtering #20329

merged 2 commits into from
Dec 19, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 19, 2022

Issue: N/A

What I did

The filtering of automigrate command was not working as intended. This PR fixes that and adds feedback in case the automigration passed does not exist.

image

Additionally, it adds a --list command to list the available automigrations.

image

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@ndelangen ndelangen self-assigned this Dec 19, 2022
@ndelangen
Copy link
Member

You made quick work out of this one @yannbf 👏

@yannbf yannbf force-pushed the fix/automigrate-filter branch from f04aca8 to 5dcfbf2 Compare December 19, 2022 16:19
@ndelangen ndelangen merged commit e3fa8a3 into next Dec 19, 2022
@ndelangen ndelangen deleted the fix/automigrate-filter branch December 19, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants