Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update Playwright to 1.29 #20318

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Build: Update Playwright to 1.29 #20318

merged 1 commit into from
Dec 18, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Dec 17, 2022

Issue:

CI is failing because there's a new version of Playwright

What I did

Updated playwright image in circleci and our own local playwright version. Similar to #19859

How to test

CI

Verified

This commit was signed with the committer’s verified signature.
ndelangen Norbert de Langen
@IanVS IanVS added the build Internal-facing build tooling & test updates label Dec 17, 2022
@IanVS IanVS requested a review from yannbf December 17, 2022 17:30
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! How can we make it so CI doesn't break every time there is a new version?

@shilman shilman merged commit 552c02f into next Dec 18, 2022
@shilman shilman deleted the playwright branch December 18, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants