Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Wrap manager entries to handle exports #20308

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

ndelangen
Copy link
Member

Issue: managerEntries must not break when one of them exports something

What I did

Wrap each managerEntry with:

import '<<>>';

...so exports from them get eleminated.

Therefore it's safe to wrap the code with a try-catch.

@ndelangen ndelangen self-assigned this Dec 16, 2022
@ndelangen ndelangen added maintenance User-facing maintenance tasks core labels Dec 16, 2022
@ndelangen ndelangen requested a review from shilman December 16, 2022 13:33
@ndelangen ndelangen changed the title Fix/manager-entry-with-exports Fix: support manager entry with exports Dec 16, 2022
@shilman shilman changed the title Fix: support manager entry with exports Core: Wrap manager entries to handle exports Dec 16, 2022
@ndelangen ndelangen merged commit c323b82 into next Dec 16, 2022
@ndelangen ndelangen deleted the fix/manager-entry-with-exports branch December 16, 2022 13:57
@ndelangen ndelangen restored the fix/manager-entry-with-exports branch December 19, 2022 16:40
@ndelangen
Copy link
Member Author

Going to open this again with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance User-facing maintenance tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants