CLI: sb migrate csf-2-to-3 doesn't work glob that uses multiple file extension #20290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #20265
What I did:
This makes tsx the default parser for csf-2-to-3. The tsx parser adds the neccesary jsx and typescript plugin to babel to parse tsx files.
Don't transform storybook source code with babel when running jscodeshift. To make it faster, and less noisy messages of:
I tried setting tsx the default parser for all codemods, but this doesn't work for all codemods for some reason. It seems a bit odd as I don't understand how adding the typescript plugin would affect the AST of non typescript files.
This also means that some codemods can not be used for TS files. Even when manually overriding the parser. Probably it is best, for new codemods, to always default to the "tsx" parser, so that we make sure it works with that config.
How to test: