Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required jobs to daily workflow #20263

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Conversation

valentinpalkovic
Copy link
Contributor

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@valentinpalkovic valentinpalkovic added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Dec 14, 2022
@ndelangen
Copy link
Member

@valentinpalkovic This seems super small, if this is green and the right thing to do according to you, please merge it 👍

@valentinpalkovic
Copy link
Contributor Author

@ndelangen I left that one open because @kasperpeulen had another solution in mind

@ndelangen
Copy link
Member

So close it then? @valentinpalkovic

@ndelangen ndelangen closed this Jan 13, 2023
@valentinpalkovic
Copy link
Contributor Author

@kasperpeulen I will merge this one. Please revert, as soon as you have a better solution in mind and implemented

@ndelangen ndelangen merged commit fef095a into next Jan 17, 2023
@ndelangen ndelangen deleted the valentin/fix-daily-workflow branch January 17, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants