SvelteKit: Support v1.0.0-next.574 and above
#20181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport-new-sveltekit
JReinhold
commented
Dec 9, 2022
| See https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#sveltekit-needs-the-storybooksveltekit-framework | ||
| ` | ||
| ); | ||
| throw new Error(); |
There was a problem hiding this comment.
This ends up as an unhandled promise rejection, but I'm unsure how to do that better while still stopping the process. I think this is okay for now.
shilman
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SvelteKit
v1.0.0-next.574introduced a split to their Vite plugins, in an attempt to make it easier for integrators (like us) to disable SvelteKit's server handling but keeping its module building. Unfortunately it is insufficient in it's current form, as keeping thevite-plugin-sveltekit-buildwill break Storybook's build output.So this PR disables both of the new SvelteKit plugins until that issue has been resolved.
See this Discord Thread for details.
This PR also changes the deprecation warning in
@storybook/svelte-viteabout switching to@storybook/sveltekitto a hard error instead, to force any users over. (upgrading users will get automigrated as of #20094)