Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: change package.json engines fields, set to minimal node16 and up #20170

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

ndelangen
Copy link
Member

Issue: our engines are stating we support node 10, this is not true, we support Node16 and up

What I did

Changed all the engines versions in our package.json files

@ndelangen ndelangen self-assigned this Dec 8, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Dec 8, 2022
@ndelangen ndelangen changed the title Tech: sync engines Tech: change package.json engines fields, set to minimal node16 and up Dec 8, 2022
@ndelangen ndelangen requested a review from kylegach December 8, 2022 18:12
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndelangen ndelangen merged commit 024ea83 into next Dec 9, 2022
@ndelangen ndelangen deleted the tech/sync-engines branch December 9, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants