Typescript: Fix bug with meta not working well as generic parameter for StoryObj #20165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
approved these changes
Dec 12, 2022
code/addons/links/package.json
Outdated
| @@ -78,7 +78,7 @@ | |||
| "dependencies": { | |||
| "@storybook/client-logger": "7.0.0-beta.0", | |||
| "@storybook/core-events": "7.0.0-beta.0", | |||
| "@storybook/csf": "next", | |||
| "@storybook/csf": "0.0.2--canary.60.011a95e.0", | |||
There was a problem hiding this comment.
will change back to next yes
kasperpeulen
force-pushed
the
kasper/sb-1071-fix-ts-bug-with-meta-not-accepted
branch
from
113cfc9 to
0fbefa5
Compare
kasperpeulen
force-pushed
the
kasper/sb-1071-fix-ts-bug-with-meta-not-accepted
branch
from
0fbefa5 to
3f6cf96
Compare
kasperpeulen
deleted the
kasper/sb-1071-fix-ts-bug-with-meta-not-accepted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug when meta is specifically typed as an object with only optional keys:
The story args will be inferred as
Record<string, any>What I did
How to test
Run yarn task --task check