Vite/MDX: Fix mdx compiler for vite #20121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
joshwooding,
shilman and
IanVS
and removed request for
joshwooding
joshwooding
approved these changes
Dec 7, 2022
shilman
changed the title
shilman
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #20116
I change the vite mdx plugin to use the mdxCompilerOptions from the preset, similar to how webpack does it now.
This could definitely be improved by your PR @joshwooding
But I'd say getting the mdxCompilerOptions from the proper place in main.js and properly exposing that as a solid public API is a secondary goal.
Primary goal is to get this working in strict installation environments such a
pnpm.