make managerEntries be loaded as ESM, for improved tree-shaking #20070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
approved these changes
Dec 2, 2022
shilman
approved these changes
Dec 3, 2022
| @@ -113,11 +119,19 @@ export const resolveAddonName = ( | |||
| const managerEntries = []; | |||
|
|
|||
| if (managerFile) { | |||
| managerEntries.push(managerFile); | |||
| // we remove the extension | |||
| // this is a bit of a hack to try en be able to find .mjs files | |||
There was a problem hiding this comment.
Suggested change
| // this is a bit of a hack to try en be able to find .mjs files | |
| // this is a bit of a hack to try to find .mjs files |
| } | ||
| // register file is the old way of registering addons | ||
| if (!managerFile && registerFile && !presetFile) { | ||
| managerEntries.push(registerFile); | ||
| // we remove the extension | ||
| // this is a bit of a hack to try en be able to find .mjs files |
There was a problem hiding this comment.
Suggested change
| // this is a bit of a hack to try en be able to find .mjs files | |
| // this is a bit of a hack to try to find .mjs files |
| return { | ||
| type: 'virtual', | ||
| name, | ||
| managerEntries: [resolved], | ||
| // we remove the extension | ||
| // this is a bit of a hack to try en be able to find .mjs files |
There was a problem hiding this comment.
Suggested change
| // this is a bit of a hack to try en be able to find .mjs files | |
| // this is a bit of a hack to try to find .mjs files |
|
arg, github only showed me your review comments after I merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
I noticed that the whole preview-api is bundled into every manager entry (
manager.mjs).I was able to assert that this is because the core-server resolves the entry fully. (to prevent pnp issues).
But by resolving it, it resolves the
cjsentry.What I did
I changed the code in
core-serverso it removes the file extension.Then I configured the manager-builder to try adding
.mjsto the path.This is not a perfect solution.
A better solution would be to somehow use the exportsMap.
I also configured esbuild to optimize the code.
before:
after:
