Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite: Reinstate (deprecated) StorybookViteConfig #20057

Merged
merged 2 commits into from
Dec 3, 2022
Merged

Vite: Reinstate (deprecated) StorybookViteConfig #20057

merged 2 commits into from
Dec 3, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Dec 2, 2022 •
edited
Loading

Issue: #19730

What I did

Export it as deprecated

How to test

See gist.github.com/mihkeleidast/af2e01ee4672804ed79d903a1093a7ab

@tmeasday tmeasday requested review from shilman and IanVS December 2, 2022 03:17
@tmeasday tmeasday requested a review from IanVS December 2, 2022 23:57
IanVS
IanVS approved these changes Dec 3, 2022
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to remove this in 8.0, then?

@shilman shilman merged commit 2c9b0f5 into next Dec 3, 2022
@shilman shilman deleted the tom/sb-918-sb19730-builder-vite-does-not-export branch December 3, 2022 01:21
@shilman shilman mentioned this pull request Dec 3, 2022
Closed
@IanVS IanVS mentioned this pull request Jan 17, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
bug builder-vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmeasday @IanVS @shilman