-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Batch the loading of CSF files for extract()
etc
#20055
Core: Batch the loading of CSF files for extract()
etc
#20055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. What's an appropriate batch size though? Isn't 100 pretty high?
Co-authored-by: Michael Shilman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…orts-in-loadallcsffiles-to
@tmeasday There seems to be some problem with this code according to chromatic:
|
Hmm, so that seems to be a weird flake, like the SB wasn't initialized properly when Still it seems pretty suspicious. I ran the CI job again and it worked. I'll run it a couple more times to be sure... |
Ok, reran it about half a dozen times without error. If anyone sees the above error again, please let me know. |
Issue: We've seen situations where
extract()
overwhelms browsers due to loading too many requests at once(only replicated on lambda-based browsers running old version of Chrome)
What I did
Batch
loadAllCsfFiles()
so it's no opening too many resources on the browser at once. The browser will only open so many requests to any given host anyway.How to test
Run extract. This should happen as part of the
chromatic-sandboxes
task.