Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: change onClick to click to support svelte examples #20034

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 30, 2022

Issue:

What I did

In Svelte, the actions panel shows click instead of onClick. The check now works for both scenarios

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the build Internal-facing build tooling & test updates label Nov 30, 2022
@yannbf yannbf force-pushed the fix/addon-actions-e2e-test branch from d175622 to ec3a465 Compare November 30, 2022 17:35
@yannbf yannbf force-pushed the fix/addon-actions-e2e-test branch from ec3a465 to 3b158fc Compare November 30, 2022 17:47
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Matching is case-insensitive and searches for a substring.
https://playwright.dev/docs/selectors#filter-by-text

@yannbf yannbf merged commit 97b4760 into next Nov 30, 2022
@yannbf yannbf deleted the fix/addon-actions-e2e-test branch November 30, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants