add backwards support for manager-api package rename #20006
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
I got this report:
https://cdn.discordapp.com/attachments/915642585761075280/1047054415040876614/Screenshot_2022-11-29_at_08.39.50.png
What I did
I think might be because the
api
package was renamed to manager-api, but I did not add an alias for it, or add it to the globals definitions object.Honestly I would have figured this to be effectively handled by the code here:
storybook/code/lib/manager-api-shim/src/entry.ts
Line 7 in 80e43ad
But maybe not?
Perhaps version conflicts can appear now, that still have the actual code, which is a problem.
If that's the case, this change should fix that.