Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Open browser after manager is ready #20005

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Core: Open browser after manager is ready #20005

merged 1 commit into from
Nov 30, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Nov 29, 2022 •
edited
Loading

fixes: #19968

What I did

Wait for the manager to start before opening the manager

@ndelangen ndelangen added the bug label Nov 29, 2022
@ndelangen ndelangen self-assigned this Nov 29, 2022
@shilman shilman changed the title open browser after manager is ready Core: Open browser after manager is ready Nov 30, 2022
@shilman shilman added the core label Nov 30, 2022
@shilman shilman merged commit afcd26c into next Nov 30, 2022
@shilman shilman deleted the norbert/sb-1022-sb19968-bug-cannot-get-when-starting branch November 30, 2022 00:41
@shilman shilman mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

@yannbf yannbf Awaiting requested review from yannbf

Assignees

@ndelangen ndelangen

Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot GET / when starting Storybook
3 participants
@ndelangen @JReinhold @shilman