Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controls: Fix file controls not resetting #19998

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Controls: Fix file controls not resetting #19998

merged 4 commits into from
Dec 8, 2022

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Nov 29, 2022 •
edited by JReinhold
Loading

#19921

What I did

Manually set value of file input to null when control value is null to make Reset controls works with file input controls

How to test

@gitstart gitstart marked this pull request as ready for review November 29, 2022 05:37
@JReinhold JReinhold self-assigned this Nov 29, 2022
JReinhold
JReinhold requested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this is great! I have a minor change request though.

code/ui/blocks/src/controls/Files.tsx Outdated Show resolved Hide resolved
@JReinhold JReinhold changed the title UI: Fix file controls not resetting Controls: Fix file controls not resetting Dec 7, 2022
JReinhold
JReinhold approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@JReinhold JReinhold merged commit f5aa7bd into storybookjs:next Dec 8, 2022
@gitstart
Copy link
Contributor Author

gitstart commented Dec 8, 2022

PR pushed through Gitstart with contributions from @BikashSah999 @phunguyenmurcul.

@shilman shilman mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees

@JReinhold JReinhold

Labels
addon: controls bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitstart @JReinhold