Svelte: Fix decorators with slots #19987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
commented
Nov 28, 2022
| * Check if an object is a svelte component. | ||
| * @param obj Object | ||
| */ | ||
| function isSvelteComponent(obj: any) { |
There was a problem hiding this comment.
This doesn't work in dev mode with Vite (and maybe with Webpack) because the component is an instance of an empty ProxyComponent instead.
I asked on the Svelte Discord for alternatives, but we haven't come up with any yet.
https://discord.com/channels/457912077277855764/1046174450749558895/1046174450749558895
JReinhold
commented
Nov 28, 2022
JReinhold
commented
Nov 29, 2022
| } = storyFn(); | ||
|
|
||
| // reactive, re-render on storyFn change | ||
| $: ({ Component, props = {}, on, Wrapper, WrapperData = {} } = storyFn()); |
There was a problem hiding this comment.
I believe these Wrapper and WrapperData were causing the issue at #19671 , because they're never set, in decorators.ts they were called decorator and decoratorProps
valentinpalkovic
approved these changes
Nov 30, 2022
Then it's good this is Svelte and not Vue 😂 |
|
For sure. xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19671
This PR fixes a regression introduced in #19580 that broke decorators in Svelte. This is the second time we've had that regression, so I've added a comment explaining that the import is weird on purpose.
It also refactors the structure around Svelte decorators and preparing them a bit. The restructuring only contains minor fixes to the logic (fixing #19671), and is mostly about readability.
I've added a few stories that tests decorators in CI (see Chromatic), and I've tested that this restructuring still works with
@storybook/addon-svelte-csf@next.