Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Add TS 4.9 CLI templates #19986

Merged
merged 1 commit into from
Nov 29, 2022
Merged

CLI: Add TS 4.9 CLI templates #19986

merged 1 commit into from
Nov 29, 2022

Conversation

kasperpeulen
Copy link
Contributor

What I did

  • Upgrade prettier to 2.8 for satisfies support
  • Upgrade ESLint TS plugin to latest canary
  • Making sure we only use TS 4.9 templates when prettier, babel and eslint deps are also in range of supporting satisfies
  • Added react, next and svelte tempaltes for TS 4.9
  • I didnt add vue2 and vue3 TS templates yet. I'm not sure about the best practices in vue with TS.

@kasperpeulen kasperpeulen force-pushed the kasper/sb-818-upgrade-to-ts-49-and-update-templates branch from 3cc3bf2 to ec8c429 Compare November 28, 2022 15:42
@socket-security
Copy link

socket-security bot commented Nov 28, 2022 •
edited
Loading

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

ndelangen
ndelangen reviewed Nov 28, 2022
View reviewed changes
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, except for some svelte changes, that seem unrelated?

code/renderers/svelte/template/cli/js/Button.svelte Outdated
Comment on lines 25 to 40

const dispatch = createEventDispatcher();

/**
* Optional click handler
*/
export let onClick = (event) => {
dispatch('click', event);
};
</script>

<button
type="button"
class={['storybook-button', `storybook-button--${size}`, mode].join(' ')}
{style}
on:click={onClick}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a new PR for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#20007

code/renderers/svelte/template/cli/js/Header.stories.js Outdated
Comment on lines 8 to 16
render: (args) => ({
Component: Header,
props: args,
on: {
login: args.onLogin,
logout: args.onLogout,
createAccount: args.onCreateAccount,
},
}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a new PR for this #20007

@kasperpeulen kasperpeulen force-pushed the kasper/sb-818-upgrade-to-ts-49-and-update-templates branch from ec8c429 to 31f581f Compare November 28, 2022 15:46
jonniebigodes
jonniebigodes approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from Norbert's feedback, all is good on my end.

@kasperpeulen kasperpeulen force-pushed the kasper/sb-818-upgrade-to-ts-49-and-update-templates branch 3 times, most recently from 06619ca to 7781b9a Compare November 29, 2022 13:50
@kasperpeulen kasperpeulen changed the base branch from next to kasper/sb-1028-cleanup-render-function-and-manual-arg November 29, 2022 13:51
@kasperpeulen kasperpeulen force-pushed the kasper/sb-1028-cleanup-render-function-and-manual-arg branch from fe7bf94 to 1b08b3f Compare November 29, 2022 14:46
Base automatically changed from kasper/sb-1028-cleanup-render-function-and-manual-arg to next November 29, 2022 15:00
@kasperpeulen kasperpeulen force-pushed the kasper/sb-818-upgrade-to-ts-49-and-update-templates branch 3 times, most recently from 43c7fc2 to 39500c0 Compare November 29, 2022 15:33
@kasperpeulen kasperpeulen mentioned this pull request Nov 29, 2022
Merged
@kasperpeulen kasperpeulen force-pushed the kasper/sb-818-upgrade-to-ts-49-and-update-templates branch 2 times, most recently from 2758c17 to 3634baf Compare November 29, 2022 15:47
@kasperpeulen kasperpeulen force-pushed the kasper/sb-818-upgrade-to-ts-49-and-update-templates branch from 3634baf to 09dd5d7 Compare November 29, 2022 16:04
@kasperpeulen kasperpeulen merged commit f45afe4 into next Nov 29, 2022
@kasperpeulen kasperpeulen deleted the kasper/sb-818-upgrade-to-ts-49-and-update-templates branch November 29, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen left review comments

@jonniebigodes jonniebigodes jonniebigodes approved these changes

@shilman shilman Awaiting requested review from shilman

@valentinpalkovic valentinpalkovic Awaiting requested review from valentinpalkovic

Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasperpeulen @ndelangen @jonniebigodes