Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon-measure: Fix measure not working on disabled elements #19985

Merged
merged 3 commits into from
Dec 9, 2022
Merged

addon-measure: Fix measure not working on disabled elements #19985

merged 3 commits into from
Dec 9, 2022

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Nov 28, 2022 •
edited by JReinhold
Loading

#17762

What I did

Replace mouseover and mousemove event with pointerover and pointermove to make measure worked on disabled button

How to test

@gitstart gitstart marked this pull request as ready for review November 28, 2022 15:47
@gitstart gitstart changed the title Addons: Fix measure not working on disabled elements Addons-Measure: Fix measure not working on disabled elements Nov 29, 2022
@gitstart gitstart changed the title Addons-Measure: Fix measure not working on disabled elements Addons-measure: Fix measure not working on disabled elements Nov 29, 2022
@JReinhold JReinhold added bug addon: measure patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Nov 29, 2022
JReinhold
JReinhold requested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, what a fantastic solution, thanks for this.

Could you rename the function at line 20 to onPointerMove too, for consistency?

@JReinhold JReinhold changed the title Addons-measure: Fix measure not working on disabled elements addon-measure: Fix measure not working on disabled elements Dec 7, 2022
@gitstart gitstart requested a review from JReinhold December 8, 2022 15:37
JReinhold
JReinhold approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺

@JReinhold JReinhold merged commit e745299 into storybookjs:next Dec 9, 2022
@gitstart
Copy link
Contributor Author

gitstart commented Dec 9, 2022

PR pushed through Gitstart with contributions from @BikashSah999 @phunguyenmurcul.

@shilman shilman mentioned this pull request Dec 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees

@JReinhold JReinhold

Labels
addon: measure bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitstart @JReinhold