Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied type adjustments to satisfy stricter Typescript compilerOption rules #19953

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Nov 24, 2022

What I did

Applied some type adjustments to satisfy stricter Typescript compilerOption rules.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@valentinpalkovic valentinpalkovic added bug maintenance User-facing maintenance tasks and removed bug labels Nov 24, 2022
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-angular-sandbox-without-no-link branch 5 times, most recently from dc30f13 to fc039fb Compare November 24, 2022 15:49
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-angular-sandbox-without-no-link branch from fc039fb to 46e2b92 Compare November 24, 2022 16:15
@valentinpalkovic valentinpalkovic marked this pull request as ready for review November 25, 2022 09:59
@valentinpalkovic valentinpalkovic changed the title Fix type issues related to Angular sandbox usage Applied type adjustments to satisfy stricter Typescript compilerOption rules Nov 25, 2022
@valentinpalkovic valentinpalkovic merged commit 55a8299 into next Nov 25, 2022
@valentinpalkovic valentinpalkovic deleted the valentin/fix-angular-sandbox-without-no-link branch November 25, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants