Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSX for Vue Components #1993

Merged
merged 5 commits into from
Oct 9, 2017

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Oct 8, 2017

Issue: #1907

What I did

Support JSX syntax for Vue Components

How to test

$ vue init webpack-simple test
$ cd test
$ $SOTRYBOOK_CLI_BIN_PATH/generate.js -f
$ yarn storybook

After the storybook starts up on browser, see the JSX story.

@codecov
Copy link

codecov bot commented Oct 8, 2017

Codecov Report

Merging #1993 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
- Coverage   21.38%   21.34%   -0.04%     
==========================================
  Files         262      262              
  Lines        5757     5767      +10     
  Branches      692      695       +3     
==========================================
  Hits         1231     1231              
+ Misses       4009     4000       -9     
- Partials      517      536      +19
Impacted Files Coverage Δ
lib/cli/lib/helpers.js 0% <0%> (ø) ⬆️
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.1% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 21% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3036b2c...6db2b3b. Read the comment docs.

@ndelangen ndelangen merged commit 1730834 into storybookjs:master Oct 9, 2017
@kazupon kazupon deleted the feature/jsx-for-vue branch October 10, 2017 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants