Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: tsup to build vite-builder #19895

Merged
merged 8 commits into from
Nov 21, 2022
Merged

Build: tsup to build vite-builder #19895

merged 8 commits into from
Nov 21, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Nov 19, 2022

Related: #18732

What I did

Migrated the vite-builder to be build with TSup

@ndelangen ndelangen requested a review from IanVS November 19, 2022 00:50
@ndelangen ndelangen self-assigned this Nov 19, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Nov 19, 2022
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can leave vite in devDependencies or it will be prebundled.

@ndelangen
Copy link
Member Author

@IanVS it's in both, therefore not pre-bundled.

@IanVS
Copy link
Member

IanVS commented Nov 21, 2022

Thanks, what is the purpose of keeping it in devDependencies if it is also in dependencies?

Norbert explained to me that we might want to keep a more broad version range in dependencies, but a more up-to-date version for devDependencies. For now they're the same, but we can change that another time.

@ndelangen ndelangen requested a review from IanVS November 21, 2022 15:55
@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package Bin script Source
[email protected] (added) webdriver-manager code/frameworks/angular/package.json via @angular-devkit/[email protected]
[email protected] (added) webdriver-manager code/frameworks/angular/package.json via @angular-devkit/[email protected], [email protected]
Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ⚠️ 2 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@ndelangen ndelangen merged commit e3b045d into next Nov 21, 2022
@ndelangen ndelangen deleted the tech/tsup-vite-builder branch November 21, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants