Fix type inference bug with decorators #19839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpeulen
force-pushed
the
kasper/fix-decorator
branch
from
eede0fe to
904ac29
Compare
kasperpeulen
force-pushed
the
kasper/fix-decorator
branch
from
904ac29 to
67a2b94
Compare
valentinpalkovic
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I stumbled on this, what I thought was an isssue with type-fest:
sindresorhus/type-fest#509 (comment)
But fixed now in a better way by adding the constraint
& keyof TArgsthanks to @papbAlso improved the ActionArgs signature.