Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextJS: Fix v13 next/link #19834

Merged
merged 4 commits into from
Nov 21, 2022
Merged

NextJS: Fix v13 next/link #19834

merged 4 commits into from
Nov 21, 2022

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Nov 14, 2022

Issue: vercel/next.js#42621 #19813

What I did

Applied the internal NEXT env var in the Storybook env

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@kylegach
Copy link
Contributor Author

These CI failures seem unrelated?

@kylegach
Copy link
Contributor Author

At Yann's suggestion, I tested in next@12. It appears the env var does have an effect in that version, so I updated this to only apply to next@13+.

@shilman shilman changed the title Fix next@13 next/link NextJS: Fix v13 next/link Nov 19, 2022
@shilman
Copy link
Member

shilman commented Nov 19, 2022

@kylegach @valentinpalkovic there's a merge conflict here -- can one of you please resolve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants