Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSF: Renamed Framework to Renderer #19802

Merged
merged 2 commits into from
Nov 13, 2022
Merged

CSF: Renamed Framework to Renderer #19802

merged 2 commits into from
Nov 13, 2022

Conversation

kasperpeulen
Copy link
Contributor

Issue:

What I did

  • I renamed Framework to Renderer

How to test

  • Checking if I my editor didn't make mistakes in any of the 133 files I guess 😅

@kasperpeulen kasperpeulen requested a review from a team November 11, 2022 11:47
@kasperpeulen kasperpeulen self-assigned this Nov 11, 2022
@kasperpeulen kasperpeulen marked this pull request as draft November 11, 2022 12:32
@kasperpeulen kasperpeulen changed the title Renamed Framework to Renderer CSF: Renamed Framework to Renderer Nov 11, 2022
tmeasday
tmeasday approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't really check all the 133 changes though :)

@kasperpeulen kasperpeulen marked this pull request as ready for review November 13, 2022 15:35
@kasperpeulen kasperpeulen force-pushed the kasper/framework-to-renderer branch from 86fd52c to dcb3159 Compare November 13, 2022 19:37
@kasperpeulen kasperpeulen merged commit bd23a5a into next Nov 13, 2022
@kasperpeulen kasperpeulen deleted the kasper/framework-to-renderer branch November 13, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees

@kasperpeulen kasperpeulen

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperpeulen @tmeasday