Fix tests on Windows #19777
Merged
Fix tests on Windows #19777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
linear
build
valentinpalkovic
requested review from
tmeasday,
ndelangen,
shilman and
kasperpeulen
valentinpalkovic
removed request for
tmeasday,
shilman,
kasperpeulen and
ndelangen
tmeasday
reviewed
Nov 9, 2022
valentinpalkovic
removed
linear
ci:daily
valentinpalkovic
force-pushed
the
valentin/fix-tests-on-windows
branch
2 times, most recently
from
8e470b7 to
f3e8952
Compare
yannbf
reviewed
Nov 9, 2022
valentinpalkovic
force-pushed
the
valentin/fix-tests-on-windows
branch
from
eb81c45 to
99e24b4
Compare
kasperpeulen
added
ci:merged
ndelangen
approved these changes
Nov 11, 2022
yannbf
reviewed
Nov 11, 2022
yannbf
reviewed
Nov 11, 2022
tmeasday
approved these changes
Nov 13, 2022
valentinpalkovic
force-pushed
the
valentin/fix-tests-on-windows
branch
2 times, most recently
from
78c3ddb to
36ede39
Compare
valentinpalkovic
force-pushed
the
valentin/fix-tests-on-windows
branch
from
36ede39 to
a6e483a
Compare
3 tasks
|
I see this has a few approvals, and I'm waiting on it to be merged for one of my PRs, so I'm going to go ahead and pull the trigger. Great work on this, @valentinpalkovic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19763 Some tests were commented out on windows because they were failing
What I did
Fixed some tests on Windows machines
How to test
yarn teston a Windows machine