Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix fix handle-release-branches workflow #19756

Merged
merged 1 commit into from
Nov 5, 2022
Merged

CI: Fix fix handle-release-branches workflow #19756

merged 1 commit into from
Nov 5, 2022

Conversation

kasperpeulen
Copy link
Contributor

What I did

  • This workflow started failing 3 months ago with the move to the code directory, addressing this change

How to test

  • I tested this by faking being next branch, which at least fixes the error. Need to merge to see the full effect on the next branch.

@kasperpeulen kasperpeulen requested a review from yannbf November 4, 2022 20:31
@kasperpeulen kasperpeulen self-assigned this Nov 4, 2022
@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label Nov 4, 2022
yannbf
yannbf approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yannbf yannbf added build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels Nov 5, 2022
@yannbf yannbf merged commit 0127a25 into next Nov 5, 2022
@yannbf yannbf deleted the kasper/fix-workflow branch November 5, 2022 14:14
@kylegach
Copy link
Contributor

kylegach commented Nov 7, 2022

Thanks for catching and fixing this, @kasperpeulen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@kasperpeulen kasperpeulen

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasperpeulen @kylegach @yannbf