-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix cross OS github actions #19754
Conversation
This library was causing issues with our current version of Jest (26) and the fact that an inner dependency is ESM only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @kasperpeulen. We should probably create some tickets to start fixing those tests I guess 🤔
@tmeasday I added a ticket for next cycle, possibly valentine can help us with it, as he has a windows dev machine. |
What I did
code
directory and ignoring some test cases on windows:Ignoring is not perfect, but in this way, we will at least not regress any further on windows.
How to test