Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix cross OS github actions #19754

Merged
merged 16 commits into from
Nov 5, 2022
Merged

CI: Fix cross OS github actions #19754

merged 16 commits into from
Nov 5, 2022

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Nov 4, 2022

What I did

  • I made all the unit tests on github action green by addressing the move to the code directory and ignoring some test cases on windows:
  'lib/core-server/src/utils/stories-json.test.ts',
  'lib/core-server/src/utils/StoryIndexGenerator.test.ts',
  'lib/cli/src/helpers.test.ts',
  'lib/core-server/src/utils/__tests__/server-statics.test.ts',
  'lib/core-common/src/utils/__tests__/template.test.ts',
  'addons/storyshots/storyshots-core/src/frameworks/configure.test.ts',
  'lib/core-common/src/utils/__tests__/interpret-files.test.ts',
  'lib/builder-manager/src/utils/files.test.ts',
  'lib/cli/src/helpers.test.ts',
  'lib/core-server/src/utils/__tests__/server-statics.test.ts',
  'lib/core-common/src/utils/__tests__/template.test.ts',
  'addons/storyshots/storyshots-core/src/frameworks/configure.test.ts',
  'lib/core-common/src/utils/__tests__/interpret-files.test.ts',
  'lib/builder-manager/src/utils/files.test.ts',
  • Change the workflow to run the cross-platform tests on every commit in pull requests, as otherwise, we will never keep maintaining this (this action has been failing for 10 months on next).

Ignoring is not perfect, but in this way, we will at least not regress any further on windows.

How to test

  • See the passing tests on GitHub action!

@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label Nov 4, 2022
@kasperpeulen kasperpeulen requested a review from kylegach November 4, 2022 13:06
@kasperpeulen kasperpeulen marked this pull request as ready for review November 4, 2022 13:06
@kasperpeulen kasperpeulen changed the title CI: Fix or remove github actions that were failing for months CI: Fix cross os github actions Nov 4, 2022
@kasperpeulen kasperpeulen changed the title CI: Fix cross os github actions CI: Fix cross OS github actions Nov 4, 2022
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @kasperpeulen. We should probably create some tickets to start fixing those tests I guess 🤔

@kasperpeulen
Copy link
Contributor Author

kasperpeulen commented Nov 5, 2022

This is great, thanks @kasperpeulen. We should probably create some tickets to start fixing those tests I guess 🤔

@tmeasday I added a ticket for next cycle, possibly valentine can help us with it, as he has a windows dev machine.

@kasperpeulen kasperpeulen merged commit 26bd203 into next Nov 5, 2022
@kasperpeulen kasperpeulen deleted the kasper/ci-stuff branch November 5, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants