Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Move all templates out of cli into renderers #19664

Merged
merged 2 commits into from
Nov 1, 2022
Merged

CLI: Move all templates out of cli into renderers #19664

merged 2 commits into from
Nov 1, 2022

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Oct 28, 2022 •
edited
Loading

This allows running tsc (or renderer-specific tsc alternatives such as svelte-check) on cli templates.

What I did

  • Include tests in tsconfig in cli package and fix tsc errors (some boy scouting)
  • Already made some logic in cli so that we can have TS 4.9 specific templates
  • Move all templates in cli into renderer packages, include those templates in tsconfig
  • Remove all templates we don't have renderers/frameworks for
  • Fix tsc/eslint errors for those moved templates
  • Migrated angular build script to tsc instead of prepare script (together with @ndelangen)

How to test

  • Testing is a bit difficult, maybe we can make a canary built for this PR @shilman I used verdaccio locally together with Norbert.

@kasperpeulen kasperpeulen self-assigned this Oct 28, 2022
@kasperpeulen kasperpeulen mentioned this pull request Oct 28, 2022
Merged
@kasperpeulen kasperpeulen added maintenance User-facing maintenance tasks and removed feature request labels Oct 28, 2022
@kasperpeulen kasperpeulen changed the title CLI: Move all templates out of cli into renderers Refactor: Move all templates out of cli into renderers Oct 28, 2022
@kasperpeulen kasperpeulen force-pushed the kasper/cli-templates branch 9 times, most recently from a481eec to 6c02686 Compare October 29, 2022 07:30
@kasperpeulen kasperpeulen changed the title Refactor: Move all templates out of cli into renderers CLI: Move all templates out of cli into renderers Oct 30, 2022
@kasperpeulen kasperpeulen force-pushed the kasper/cli-templates branch 3 times, most recently from a12c002 to d236c89 Compare October 30, 2022 06:37
shilman
shilman reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a pretty big change! Generally looking good, but I have a few questions

code/frameworks/angular/package.json Show resolved Hide resolved
code/frameworks/angular/package.json Show resolved Hide resolved
code/frameworks/nextjs/template/cli/js/Header.jsx Show resolved Hide resolved
code/frameworks/nextjs/template/cli/js/Page.jsx Outdated Show resolved Hide resolved
code/lib/cli/src/generators/AURELIA/index.ts Show resolved Hide resolved
code/lib/cli/src/project_types.ts Show resolved Hide resolved
code/renderers/html/template/cli/ts/Button.stories.ts Outdated Show resolved Hide resolved
code/package.json Outdated Show resolved Hide resolved
@shilman shilman added the cli label Oct 31, 2022
shilman
shilman approved these changes Nov 1, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@shilman shilman merged commit f02422a into next Nov 1, 2022
@shilman shilman deleted the kasper/cli-templates branch November 1, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@yannbf yannbf Awaiting requested review from yannbf

Assignees

@kasperpeulen kasperpeulen

Labels
cli csf3 maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperpeulen @shilman