Svelte: Fix regression causing all stories to error #19653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not quite sure why there would be two copies of Svelte. If you can figure out what the two copies are then maybe that'd give us something more to go off of |
JReinhold
approved these changes
Oct 27, 2022
JReinhold
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19634
What I did
Reverted a change made in https://github.com/storybookjs/storybook/pull/19512/files#diff-8e2b2768c655a2de34733307ce49b791b83cbee8126497632f03be49f00c7bfb.
I'm not 100% certain why this change broke svelte. The closest I could come was a mention in https://stackoverflow.com/questions/64847693/uncaught-error-target-is-a-required-option-svelte about different copies of svelte being used to render the components. Maybe @benmccann would know more. But at least this change fixes it.
How to test
yarn task --task sandbox --template svelte-vite/default-js
cd sandbox/svelte-vite-default-js/
yarn storybook
Open any story, it should render without error