Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-storybook: Only copy .mjs files for manager build #19647

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

ndelangen
Copy link
Member

reduces the size of a deployed storybook by about 12MB!

The manager is build using ESM only, the JS files generated are only for the builder to read which globals to inject into addons.
Only the .mjs files need to be copied.

@ndelangen ndelangen self-assigned this Oct 27, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Oct 27, 2022
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡🔬

@shilman shilman changed the title only copy .mjs files from from storybook/manager/dist in manager-builder Build-storybook: Only copy .mjs files for manager build Oct 27, 2022
@shilman shilman added the core label Oct 27, 2022
@shilman shilman merged commit da4bf6e into next Oct 27, 2022
@shilman shilman deleted the tech/only-copy-mjs-to-manager-outpout branch October 27, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants