-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move examples -> test-storybooks #19599
Move examples -> test-storybooks #19599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 x 💯
…ning-examples-to-old-examples
e7356d5
to
0c9e1ed
Compare
Socket Security ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 New install scripts detectedA dependency change in this PR is introducing new install scripts to your install step.
🧌 Troll package addedThis package is a joke. You should not use it in production.
Socket.dev scan summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
0c9e1ed
to
9a92922
Compare
@tmeasday I think this PR broke Netlify deployments. See this PR's deployments at https://app.netlify.com/sites/storybookjs/deploys/63576db9580f310009ed9701:
It is looking for |
Yes it sure did! Discussed with @shilman he told me we are going to figure it out w/ @ndelangen |
code/
's deps)The plan is to add new circle jobs to e.g. E2E test, or run Chromatic against these examples. I haven't done that yet as I am not sure which ones we want to test. Currently on
next
the only remaining example SB we run Chromatic against is thedoc-blocks
repo, which is the one I am expecting @JReinhold to delete soon.Note for example that AFAIK the ember example doesn't work right now due to framework issues.
PS
code/node_modules
goes from 2.2->1.8G which should help a little with circle times amongst other things.